tflobbe commented on a change in pull request #1774:
URL: https://github.com/apache/lucene-solr/pull/1774#discussion_r475802739
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -719,6 +719,7 @@ public void load() {
createHandler(ZK_PATH, ZookeeperInfoHandler.class.getName(),
ZookeeperInfoHandler.class);
createHandler(ZK_STATUS_PATH, ZookeeperStatusHandler.class.getName(),
ZookeeperStatusHandler.class);
collectionsHandler = createHandler(COLLECTIONS_HANDLER_PATH,
cfg.getCollectionsHandlerClass(), CollectionsHandler.class);
+ healthCheckHandler = loader.newInstance(cfg.getHealthCheckHandlerClass(),
HealthCheckHandler.class, null, new Class<?>[]{CoreContainer.class}, new
Object[]{this});
Review comment:
@chatman, looking a bit at the Packages code. Is the idea that we need
to use `PackageListeningClassLoader`? That's not currently used in
CoreContainer, and I only see it for loading schema plugins. Maybe I'm missing
something. If none of the existing top level handlers can be loaded from
packages, then we probably want to tackle that in a different Jira issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]