rishisankar commented on a change in pull request #1770:
URL: https://github.com/apache/lucene-solr/pull/1770#discussion_r474320477
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java
##########
@@ -476,8 +478,11 @@ public void registerDocCollectionWatcher(String
collection, DocCollectionWatcher
assertZKStateProvider().zkStateReader.registerDocCollectionWatcher(collection,
watcher);
}
+ // TODO: async direct updates
Review comment:
Before going further with this implementation, I wanted to get another
opinion on the general implementation approach I'm taking here -- i.e. changing
internal methods to return a CompletableFuture even for synchronous requests,
except that they are already completed unless the request is async. A perhaps
more hacky alternative is wrapping the CompletableFuture within a NamedList
(similar to what I did [here](https://github.com/apache/lucene-solr/pull/1688)).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
