[ https://issues.apache.org/jira/browse/SOLR-14691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181444#comment-17181444 ]
Andrzej Bialecki commented on SOLR-14691: ----------------------------------------- I initially set the priority to Major and I stand by my assessment ;) . I will eventually get to it but if someone else can take it first I won't stand in the way. > Metrics reporting should avoid creating objects > ----------------------------------------------- > > Key: SOLR-14691 > URL: https://issues.apache.org/jira/browse/SOLR-14691 > Project: Solr > Issue Type: Improvement > Components: metrics > Reporter: Andrzej Bialecki > Priority: Critical > Fix For: 8.7 > > > {{MetricUtils}} unnecessarily creates a lot of short-lived objects (maps and > lists). This affects GC, especially since metrics are frequently polled by > clients. We should refactor it to use {{MapWriter}} as much as possible. > Alternatively we could provide our wrappers or subclasses of Codahale metrics > that implement {{MapWriter}}, then a lot of complexity in {{MetricUtils}} > wouldn't be needed at all. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org