mayya-sharipova commented on pull request #1725:
URL: https://github.com/apache/lucene-solr/pull/1725#issuecomment-677849598
@jimczi Thank you for the initial feedback. I have tried to address it.
Please continue to review, when you have time.
I have caught up with @jimczi offline, and his main comment was that we
need to redesign all comparators is such a way that they all provide skipping
functionality by default (without wrapping them into FilteringComparator and
FilteringLeafComparator). While this be a target of following PRs, the goal
of this PR is do this only for `DocComparator`.
So addressing @jimczi's feedback, in this PR:
- `DocComparator` was redesigned to have skipping functionality be default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
