sigram commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r473852648
########## File path: solr/core/src/java/org/apache/solr/cluster/events/ScheduledEvent.java ########## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.cluster.events; + +/** + * + */ +public interface ScheduledEvent extends ClusterEvent { Review comment: > plugged into the autoscaling framework This PR is NOT just about the autoscaling. The goal is to define a generic API for cluster-level events. Autoscaling plugins will be just one consumer of this API. > IOW, ScheduledEvent should not be a first class concept/interface in "solr-core" I disagree. Scheduling various maintenance tasks is a common need (not just in autoscaling), and it fits with the event API. Sure, we can define a separate API just for scheduling, but it would be still something that belongs to solr-core. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
