adorow opened a new pull request #1759: URL: https://github.com/apache/lucene-solr/pull/1759
<!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr: * https://issues.apache.org/jira/projects/LUCENE * https://issues.apache.org/jira/projects/SOLR You will need to create an account in Jira in order to create an issue. The title of the PR should reference the Jira issue number in the form: * LUCENE-####: <short description of problem or changes> * SOLR-####: <short description of problem or changes> LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description On collection delete, also delete its config set iff it has been auto-created and if there are no other references to it. # Solution The following steps are followed on (the end of) DeleteCollectionCmd: * read config set name * if it is auto-created (suffixed with ".AUTOCREATED"), then: * verify if any other collection uses the same config set * if no other collection uses the same config set; then delete it *Notes*: some comments were added referring to some other codes that do some similar things (like for finding out the configSetName of other collections). Maybe there's a better, reusable way of doing that - like triggering an extra command for deleting the config set, that my limited knowledge in the code has not figured out. # Tests Existing tests run successfully. Added a new test: CollectionDeleteAlsoDeletesAutocreatedConfigSetTest. A collection is created (with it an auto-created config set is added. The collection is deleted, and it is verified that the ".AUTOCREATED" config set has also been deleted. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. (an issue already existed) - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `master` branch. - [x] I have run `ant precommit` and the appropriate test suite. (./gradlew check was executed, which seems to be applying the same checks) - [x] I have added tests for my changes. - [x] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org