dsmiley commented on a change in pull request #1602:
URL: https://github.com/apache/lucene-solr/pull/1602#discussion_r466589294
##########
File path: solr/core/src/test/org/apache/solr/update/SolrIndexConfigTest.java
##########
@@ -208,4 +210,16 @@ public void testToMap() throws Exception {
assertEquals(mSizeExpected, m.size());
}
+
+ public void testMaxCommitMergeWaitSeconds() throws Exception {
+ SolrConfig sc = new SolrConfig(TEST_PATH().resolve("collection1"),
"solrconfig-test-misc.xml");
+ assertEquals(-1, sc.indexConfig.maxCommitMergeWaitMillis);
+ assertEquals(IndexWriterConfig.DEFAULT_MAX_COMMIT_MERGE_WAIT_MILLIS,
sc.indexConfig.toIndexWriterConfig(h.getCore()).getMaxCommitMergeWaitMillis());
+ System.setProperty("solr.tests.maxCommitMergeWait", "10");
+ sc = new SolrConfig(TEST_PATH().resolve("collection1"),
"solrconfig-test-misc.xml");
+ assertEquals(10, sc.indexConfig.maxCommitMergeWaitMillis);
+ assertEquals(10,
sc.indexConfig.toIndexWriterConfig(h.getCore()).getMaxCommitMergeWaitMillis());
+ System.clearProperty("solr.tests.maxCommitMergeWait");
Review comment:
Please verify if this is so before removing. Perhaps there may be a
difference in behavior between gradle & IntelliJ; so try both. I thought
clearing wasn't necessary as well but I recall hearing from someone (@dweiss ?)
that the auto-clearing wasn't working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
