dsmiley opened a new pull request #1723: URL: https://github.com/apache/lucene-solr/pull/1723
The intent of this is to simplify some concurrent code in the Prometheus exporter that I think is too confusing / contorted -- particularly Async.java. Git blame points at @shalinmangar so I would love a review to see what you think. I played with a few different approaches, and ultimately realized that we're working around using an Executor instead of an ExecutorService to benefit from invokeAll. I wish Java didn't have a distinction between Executor & ExecutorService but there is and we should all just ignore plain Executor IMO. I haven't run this in-the-field but I could do so locally. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
