jpountz edited a comment on pull request #1543:
URL: https://github.com/apache/lucene-solr/pull/1543#issuecomment-669927391
> But, couldn't we instead just subclass Lucene's default codec, override
{{getDocValuesFormatPerField}} to subclass {{Lucene80DocValuesFormat}} (oh, I
see, yeah we cannot do that -- this class is final, which makes sense). I was
thinking since this (whether to compress each block) is purely a write time
decision, it could still be done as Lucene80 doc values format SPI.
To me we only guarantee backward compatibility for users of the default
codec. With the approach you mentioned, indices would be backward compatible,
but I'm seeing this as accidental rather than something we guarantee.
> But then I wonder why not just add a boolean compress option to
Lucene80DocValuesFormat? This is similar to the compression Mode we pass to
stored fields and term vectors format at write time, and it'd allow users who
would like to disable BINARY doc values compression to keep backwards
compatibility.
I wanted to look into whether we could avoid this as it would boil down to
maintaining two doc-value formats, but this might be the best way forward as it
looks like the heuristics we tried out above don't work well to disable
compression for use-cases when it hurts more than it helps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
