HoustonPutman commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r465146599
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Clause.java
##########
@@ -686,7 +686,7 @@ boolean isShardAbsent() {
for (Row r : session.matrix) {
computedValueEvaluator.node = r.node;
SealedClause sealedClause = getSealedClause(computedValueEvaluator);
- if (!sealedClause.getGlobalTag().isPass(r)) {
+ if (r.isLive() && !sealedClause.getGlobalTag().isPass(r)) {
Review comment:
I brought this back in from the revert because it looks like an
improvement that was unrelated to the default policy.
I'm happy to remove it if y'all think I should.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
