MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464826399



##########
File path: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java
##########
@@ -236,27 +236,27 @@ public IndexFetcher(@SuppressWarnings({"rawtypes"})final 
NamedList initArgs, fin
     if (fetchFromLeader != null && fetchFromLeader instanceof Boolean) {
       this.fetchFromLeader = (boolean) fetchFromLeader;
     }
-    Object skipCommitOnMasterVersionZero = 
initArgs.get(SKIP_COMMIT_ON_MASTER_VERSION_ZERO);
-    if (skipCommitOnMasterVersionZero != null && skipCommitOnMasterVersionZero 
instanceof Boolean) {
-      this.skipCommitOnMasterVersionZero = (boolean) 
skipCommitOnMasterVersionZero;
+    Object skipCommitOnPrimaryVersionZero = 
initArgs.get(SKIP_COMMIT_ON_MASTER_VERSION_ZERO);

Review comment:
       It doesn't have to handle back-compat in this PR. I can commit to it 
prior to 9.0's release and even prioritize the work before opening PRs on the 
other work I am doing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to