MarcusSorealheis commented on a change in pull request #1712: URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464128075
########## File path: solr/core/src/java/org/apache/solr/security/JWTVerificationkeyResolver.java ########## @@ -106,7 +106,7 @@ public Key resolveKey(JsonWebSignature jws, List<JsonWebStructure> nestingContex } } - // Add all keys into a master list + // Add all keys into a primary list Review comment: yea, that was a screw up of mine. I would say this can stay master as I have no inherent problem with the word `master` outside of the context of `master/slave`. However, I agree that probably best to remove this one in this case because others do. I'll change it to reference. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org