munendrasn commented on a change in pull request #1707:
URL: https://github.com/apache/lucene-solr/pull/1707#discussion_r463944894
##########
File path: solr/core/src/java/org/apache/solr/search/facet/FacetRequest.java
##########
@@ -163,15 +166,23 @@ public boolean canBecomeNonEmpty() {
/** Are we doing a query time join across other documents */
public static class JoinField {
+ public static final String FROM_PARAM = "from";
+ public static final String TO_PARAM = "to";
+ public static final String METHOD_PARAM = "method";
+ public static final Set<String> SUPPORTED_JOIN_PROPERTIES =
Sets.newHashSet(FROM_PARAM, TO_PARAM, METHOD_PARAM);
Review comment:
these variables could be package-private
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
