[ 
https://issues.apache.org/jira/browse/SOLR-14696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168202#comment-17168202
 ] 

David Smiley commented on SOLR-14696:
-------------------------------------

[~noble.paul] it appears this was introduced by you a long time ago.  I think 
you may have the best sense of the appropriate fix.  I thought maybe the only 
attributes that mattered were some built-in meta ones, but I'm seeing it looks 
like I was wrong; lots of stuff are pulled from attributes.  Maybe this 
constructor should just go away because it's ambiguous?

BTW PluginInfo.toMap seems poor because it combined attributes and initArgs as 
if it was one map which isn't a correct model of the true structure.

> PluginInfo attribute values should only be Strings
> --------------------------------------------------
>
>                 Key: SOLR-14696
>                 URL: https://issues.apache.org/jira/browse/SOLR-14696
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Priority: Minor
>
> PluginInfo has a constructor that initializes its attributes field 
> (Map<String,String>) to that of a constructor param (Map<String,Object>).  
> Sometimes, the values aren't Strings, yet the code suppresses warnings about 
> this and just sets it any way.  This is nasty!
> Perhaps it should only let through some built-in meta names like name, class, 
> and enabled that are or can trivially be coerced to a String.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to