ctargett commented on pull request #1700: URL: https://github.com/apache/lucene-solr/pull/1700#issuecomment-664755552
This is only a problem if you already had it installed before it was upgraded several months ago. At that time, I sent mail to the Dev list explaining the need for people to specifically upgrade, and it’s explained in the Jira issue I used at that time. I’m on vacation, so I’ll leave searching for those things up to you. For people who never installed any of the dependencies, I believe the right version of the gem gets installed with jekyll-asciidoc gem, it just doesn’t upgrade it if you already have it, which is why I’d removed it from the README. And as soon as we move to Gradle, the need for any dependencies goes away entirely. So what you choose to do with this PR with all that info is up to you, but I’d prefer it be clear and accurate about who needs the extra step. As I mentioned, I’m on vacation, so won’t be reviewing this again until next week at the earliest. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
