chatman commented on a change in pull request #1679:
URL: https://github.com/apache/lucene-solr/pull/1679#discussion_r456133302
##########
File path:
solr/core/src/test/org/apache/solr/cloud/MetricsHistoryIntegrationTest.java
##########
@@ -59,38 +59,24 @@
@BeforeClass
public static void setupCluster() throws Exception {
- boolean simulated = TEST_NIGHTLY ? random().nextBoolean() : true;
- if (simulated) {
- cloudManager = SimCloudManager.createCluster(1,
TimeSource.get("simTime:50"));
- solrClient = ((SimCloudManager)cloudManager).simGetSolrClient();
- }
configureCluster(1)
.addConfig("conf", configset("cloud-minimal"))
.configure();
- if (!simulated) {
- cloudManager =
cluster.getJettySolrRunner(0).getCoreContainer().getZkController().getSolrCloudManager();
- solrClient = cluster.getSolrClient();
- }
+ cloudManager =
cluster.getJettySolrRunner(0).getCoreContainer().getZkController().getSolrCloudManager();
+ solrClient = cluster.getSolrClient();
timeSource = cloudManager.getTimeSource();
// create .system
CollectionAdminRequest.createCollection(CollectionAdminParams.SYSTEM_COLL,
null, 1, 1)
.process(solrClient);
CloudUtil.waitForState(cloudManager, CollectionAdminParams.SYSTEM_COLL,
30, TimeUnit.SECONDS, CloudUtil.clusterShape(1, 1));
solrClient.query(CollectionAdminParams.SYSTEM_COLL, params(CommonParams.Q,
"*:*"));
- // sleep a little to allow the handler to collect some metrics
- if (simulated) {
- timeSource.sleep(90000);
- } else {
- timeSource.sleep(100000);
- }
+ // sleep until next generation of kids grow up to allow the handler to
collect some metrics
Review comment:
@markrmiller @noblepaul any thoughts here, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
