[
https://issues.apache.org/jira/browse/SOLR-11262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158944#comment-17158944
]
Munendra S N commented on SOLR-11262:
-------------------------------------
{quote}The issue is a bug but in CHANGES.txt it's listed as an improvement.
Could a user encounter this as a bug? It seems so based on Yonik's
description.{quote}
XMLWriter implements TextWriter which implements PushWriter. Currently,
writeMap and writeIterator are no-op in TextWriter (default implementation).
None of the components use MapWriter or IteratorWriter, primary reason was
because XMLWriter was no-op. Since, no user functionality was affected, I added
it to improvements instead of bug. Let me know if this fits bug category than
improvement, i will move the changes entry to bug section
{quote}Also, please try to write the CHANGES.txt in a way a user might be able
to understand – users know about /terms and wt=xml but not "Implement writeMap
and writeIterator in XMLWriter".{quote}
As this currently doesn't affect any functionality I couldn't think of any
better changes entry but I understand users might not understand current entry.
I will rethink again and come up with user-friendly changes entry. Any help
here is really appreciated :)
> XML writer does not implement PushWriter
> ----------------------------------------
>
> Key: SOLR-11262
> URL: https://issues.apache.org/jira/browse/SOLR-11262
> Project: Solr
> Issue Type: Bug
> Reporter: Yonik Seeley
> Assignee: Munendra S N
> Priority: Major
> Fix For: 8.7
>
> Attachments: SOLR-11262.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> While implementing points support for the terms component in a streaming
> manner (via PushWriter/MapWriter) I discovered that the XML response writer
> does not implement this interface.
> This means that any code using PushWriter (via MapWriter or IteratorWriter)
> will be broken if one tries to use XML response format. This may easily go
> unnoticed if one is not using XML response format in testing (JSON or binary
> is frequently used).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
