noblepaul commented on a change in pull request #1669:
URL: https://github.com/apache/lucene-solr/pull/1669#discussion_r454704926
##########
File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java
##########
@@ -188,6 +190,7 @@ public IndexSchema(String name, InputSource is, Version
luceneVersion, SolrResou
protected IndexSchema(Version luceneVersion, SolrResourceLoader loader,
Properties substitutableProperties) {
this.luceneVersion = Objects.requireNonNull(luceneVersion);
this.loader = loader;
+ this.solrClassLoader = loader.getCore() == null? loader:
loader.getCore().getSchemaPluginsLoader();
Review comment:
> What if SchemaPluginsLoader was an SRL itself, and delegated the
resource-loading methods to the "real" SRL?
Well, technically it's possible. The current SRL is a mess. At some point in
the future we may end up making it clean and usable. Today it's not. We should
clearly differentiate between places where we need to load resources and places
where we need to load classes. A Minimal interface should be enough for loading
classes. SRL is a heavy concrete class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
