[
https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157071#comment-17157071
]
Erick Erickson commented on SOLR-13939:
---------------------------------------
[~dweiss] For once a non-Gradle question I'd like your input on. The PR 1668
adds exceptions to thread leak detection, but some of the same ones are in
superclasses, are the ones in subclasses redundant?
The class hierarchy in one case is:
SolrTestCase
SolrTestCaseJ4
SolrCloudTestCase
CollectionsAPIDistributedZkTest
HdfsCollectionsAPIDistributedZkTest
SolrTestCase has:
{code:java}
@ThreadLeakFilters(defaultFilters = true, filters = {
SolrIgnoredThreadsFilter.class })
{code}
SolrTestCaseJ4 has
{code:java}
@ThreadLeakFilters(defaultFilters = true, filters = {
SolrIgnoredThreadsFilter.class,
QuickPatchThreadsFilter.class
})
{code}
and HdfsCollectionsAPIDistributedZkTest
has:
{code:java}
@ThreadLeakFilters(defaultFilters = true, filters = {
SolrIgnoredThreadsFilter.class,
QuickPatchThreadsFilter.class,
BadHdfsThreadsFilter.class // hdfs currently leaks thread(s)
})
{code}
Is the inclusion of SolrIgnoredThreadFilter.class and
QuickPatchTHreadsFilter.class redundant given those are in the superclasses?
For that matter, is the SolrIgnoredThreadsFilter also redundant in
SolrTestCaseJ4?
What I have in mind is putting SolrIgnoredThreadsFilter.class and
QuickPatchThradsFilter.class in SolrTestCase and removing them everywhere else
that inherits from SolrTestCase and making other appropriate adjustments. That
depends on multiple @ThreadLeakFilters annotations being additive.
Thanks!
> Extract any non-gradle related patches (deprecations, URL fixes, etc.) from
> gradle effort
> -----------------------------------------------------------------------------------------
>
> Key: SOLR-13939
> URL: https://issues.apache.org/jira/browse/SOLR-13939
> Project: Solr
> Issue Type: Sub-task
> Reporter: Dawid Weiss
> Assignee: Erick Erickson
> Priority: Major
> Attachments: SOLR-13939.patch, eoe_merged.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
