[ 
https://issues.apache.org/jira/browse/SOLR-14637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156840#comment-17156840
 ] 

David Eric Pugh commented on SOLR-14637:
----------------------------------------

[~asalamon74]I opened up https://github.com/apache/lucene-solr/pull/1670 for 
this, thanks!   

What do you think in the two code examples of removing the two lines:

.withConnectionTimeout(10000)
        .withSocketTimeout(60000

I don't think they required, and they make it a bit harder to see the key 
difference between `solrj-cloudsolrclient-zookeepernoroot` and 
`solrj-cloudsolrclient-zookeeperroot` examples.

> Update CloudSolrClient examples
> -------------------------------
>
>                 Key: SOLR-14637
>                 URL: https://issues.apache.org/jira/browse/SOLR-14637
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Andras Salamon
>            Assignee: David Eric Pugh
>            Priority: Minor
>         Attachments: SOLR-14637.patch, SOLR-14637.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> CloudSolrClient.Builder() is deprecated ( SOLR-11629 ) but in the 
> documentation we still use this constructor. I think it would be better to 
> use a non-deprecated constructor in the examples.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to