noblepaul commented on a change in pull request #1666:
URL: https://github.com/apache/lucene-solr/pull/1666#discussion_r453280161
##########
File path: solr/core/src/java/org/apache/solr/core/PluginInfo.java
##########
@@ -66,27 +66,39 @@ public PluginInfo(String type, Map<String, String> attrs,
@SuppressWarnings({"ra
* This checks if it is a package name prefixed classname.
* the return value has first = package name and second = class name
*/
- public static Pair<String,String > parseClassName(String name) {
- String pkgName = null;
- String className = name;
- if (name != null) {
+ public static CName parseClassName(String name) {
+ return new CName(name);
+ }
+
+ public static class CName {
+ public final String pkg;
+ public final String className;
+
+ public CName(String name) {
+ if (name == null) {
Review comment:
Well, in the current code there are a few places where class name is
passed as `null`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
