[
https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154878#comment-17154878
]
ASF subversion and git services commented on LUCENE-8574:
---------------------------------------------------------
Commit 60e0d8ac6e512008d68770c358af8f057b03566d in lucene-solr's branch
refs/heads/master from Michael McCandless
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=60e0d8a ]
LUCENE-8574: the DoubleValues for dependent bindings for an expression are now
cached and reused and no longer inefficiently recomputed per hit
> ExpressionFunctionValues should cache per-hit value
> ---------------------------------------------------
>
> Key: LUCENE-8574
> URL: https://issues.apache.org/jira/browse/LUCENE-8574
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 7.5, 8.0
> Reporter: Michael McCandless
> Assignee: Robert Muir
> Priority: Major
> Attachments: LUCENE-8574.patch, unit_test.patch
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> The original version of {{ExpressionFunctionValues}} had a simple per-hit
> cache, so that nested expressions that reference the same common variable
> would compute the value for that variable the first time it was referenced
> and then use that cached value for all subsequent invocations, within one
> hit. I think it was accidentally removed in LUCENE-7609?
> This is quite important if you have non-trivial expressions that reference
> the same variable multiple times.
> E.g. if I have these expressions:
> {noformat}
> x = c + d
> c = b + 2
> d = b * 2{noformat}
> Then evaluating x should only cause b's value to be computed once (for a
> given hit), but today it's computed twice. The problem is combinatoric if b
> then references another variable multiple times, etc.
> I think to fix this we just need to restore the per-hit cache?
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
