dweiss commented on a change in pull request #1634:
URL: https://github.com/apache/lucene-solr/pull/1634#discussion_r448185712
##########
File path: solr/core/build.gradle
##########
@@ -138,6 +138,8 @@ dependencies {
testImplementation ('com.sun.jersey:jersey-servlet') { transitive = false }
+ // required for instantiating a Zookeeper server in tests or embedded
+ runtimeOnly ('org.xerial.snappy:snappy-java') { transitive = false }
Review comment:
gradlew dependencies is the way to go as it shows you exactly which
dependencies it includes (for each configuration). This means that
compilation-time dependencies may be different than runtime dependencies, for
example. For a given configuration it will show you the subtree of dependencies
for a given entry. If snappy doesn't have any sub-dependencies then the subtree
is empty.
Alternatively, you can take a look at the pom file directly. :)
https://repo1.maven.org/maven2/org/xerial/snappy/snappy-java/1.1.7.6/snappy-java-1.1.7.6.pom
I only see test dependencies and "provided" which isn't included
transitively. So you can remove that "transitive = false" block as it doesn't
do anything for snappy. It is weird to me that this dependency isn't included
by zookeeper itself (it should be!). Perhaps it's because zookeeper is declared
with transitive=false. If so then a much better way to solve this would be to
remove the explicit snappy dependency and just include it transitively with
zookeeper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
