ctargett commented on a change in pull request #1625:
URL: https://github.com/apache/lucene-solr/pull/1625#discussion_r446983370
##########
File path: solr/solr-ref-guide/src/docvalues.adoc
##########
@@ -24,7 +24,7 @@ The standard way that Solr builds the index is with an
_inverted index_. This st
For other features that we now commonly associate with search, such as
sorting, faceting, and highlighting, this approach is not very efficient. The
faceting engine, for example, must look up each term that appears in each
document that will make up the result set and pull the document IDs in order to
build the facet list. In Solr, this is maintained in memory, and can be slow to
load (depending on the number of documents, terms, etc.).
-In Lucene 4.0, a new approach was introduced. DocValue fields are now
column-oriented fields with a document-to-value mapping built at index time.
This approach promises to relieve some of the memory requirements of the
fieldCache and make lookups for faceting, sorting, and grouping much faster.
+In Lucene 4.0, a new approach was introduced. DocValue fields are now
column-oriented fields with a document-to-value mapping built at index time.
This approach promises to relieve some of the memory requirements of the
fieldCache and make lookups for faceting, sorting much faster.
Review comment:
If you're going to take a word out of the list and leave only 2 items,
you should remove the comma and add "and" instead: `...make lookups for
faceting and sorting much faster`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
