ErickErickson commented on pull request #1626:
URL: https://github.com/apache/lucene-solr/pull/1626#issuecomment-650812400


   I left some comments, I need to look at the code more closely before I 
finish.
   
   > On Jun 28, 2020, at 2:03 PM, Atri Sharma <[email protected]> wrote:
   > 
   > This commit consists of two parts: add circuit breakers infrastructure and 
a "real" JVM heap memory based
   > circuit breaker which monitors incoming search requests and rejects them 
with SERVICE_TOO_BUSY error
   > if the defined threshold is breached, thus giving headroom to existing 
indexing and search requests
   > to complete.
   > 
   > You can view, comment on, or merge this pull request online at:
   > 
   >   https://github.com/apache/lucene-solr/pull/1626
   > 
   > Commit Summary
   > 
   >    • SOLR-14588: Implement Circuit Breakers
   > File Changes
   > 
   >    • M solr/CHANGES.txt (1)
   >    • M 
solr/contrib/clustering/src/test-files/clustering/solr/collection1/conf/solrconfig.xml
 (11)
   >    • M 
solr/contrib/prometheus-exporter/src/test-files/solr/collection1/conf/solrconfig.xml
 (4)
   >    • M solr/core/src/java/org/apache/solr/core/SolrConfig.java (19)
   >    • M solr/core/src/java/org/apache/solr/core/SolrCore.java (16)
   >    • M 
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java (32)
   >    • A 
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java (55)
   >    • A 
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java
 (128)
   >    • A 
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerType.java 
(26)
   >    • A 
solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java
 (97)
   >    • M solr/core/src/resources/EditableSolrConfigAttributes.json (2)
   >    • M 
solr/core/src/test-files/solr/collection1/conf/solrconfig-cache-enable-disable.xml
 (4)
   >    • M 
solr/core/src/test-files/solr/collection1/conf/solrconfig-elevate.xml (4)
   >    • M 
solr/core/src/test-files/solr/collection1/conf/solrconfig-implicitproperties.xml
 (2)
   >    • A 
solr/core/src/test-files/solr/collection1/conf/solrconfig-memory-circuitbreaker.xml
 (91)
   >    • M 
solr/core/src/test-files/solr/collection1/conf/solrconfig-sortingresponse.xml 
(4)
   >    • M solr/core/src/test-files/solr/collection1/conf/solrconfig.xml (10)
   >    • M solr/core/src/test-files/solr/collection1/conf/solrconfig_perf.xml 
(2)
   >    • M solr/core/src/test/org/apache/solr/core/SolrCoreTest.java (2)
   >    • M solr/core/src/test/org/apache/solr/core/TestConfigOverlay.java (2)
   >    • A solr/core/src/test/org/apache/solr/util/TestCircuitBreaker.java 
(227)
   >    • M solr/example/example-DIH/solr/db/conf/solrconfig.xml (10)
   >    • M solr/example/example-DIH/solr/mail/conf/solrconfig.xml (10)
   >    • M solr/example/example-DIH/solr/solr/conf/solrconfig.xml (10)
   >    • M solr/example/files/conf/solrconfig.xml (30)
   >    • M solr/server/solr/configsets/_default/conf/solrconfig.xml (10)
   >    • M 
solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml (10)
   >    • A solr/solr-ref-guide/src/circuit-breakers.adoc (81)
   >    • M solr/solr-ref-guide/src/config-api.adoc (7)
   >    • M solr/solr-ref-guide/src/index.adoc (3)
   >    • M solr/solr-ref-guide/src/query-settings-in-solrconfig.adoc (20)
   > Patch Links:
   > 
   >    • https://github.com/apache/lucene-solr/pull/1626.patch
   >    • https://github.com/apache/lucene-solr/pull/1626.diff
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   > 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to