[
https://issues.apache.org/jira/browse/SOLR-14592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147366#comment-17147366
]
Erick Erickson commented on SOLR-14592:
---------------------------------------
Well, this will be a little trickier than I thought. The background is here:
https://github.com/apache/zookeeper/pull/1048/files, see the comments in the
file zookeeperAdmin.md
Root question. Do we need SolrZKServer.getMyServerId()? It's only used if the
myId file is missing. Is this a legitimate patch-up? The code is very old, it's
possible this was put in there for reasons that are no longer valid. Starting
up with embedded ZK doesn't seem to use this code....
tl;dr;
SolrZKServer.getMyServerId
won't compile any more.
{code}
for (QuorumPeer.QuorumServer server : slist.values()) {
if (server.addr.getHostName().equals(myHost)) {
{code}
The thing I see in the Zookeeper code is something like
{code}
sever.addr.getReachableAddress().getHostName()...
{code}
Problem there is that the return from getReachableAddress is indeterminate, so
inferring the id from the address is probably not the right thing to do.
Before going down the path of trying to find the right thing to do I thought
I'd ask if this rings any bells. Meanwhile, I'll remove the code and see if
tests fail.
The kind of issue is a very good reason _NOT_ to try to get this into 8.6. BTW.
> Upgrade Zookeeper to 3.6.1
> --------------------------
>
> Key: SOLR-14592
> URL: https://issues.apache.org/jira/browse/SOLR-14592
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
>
> We're two releases behind, seems like A Good Thing to upgrade. I'm usually
> reluctant to upgrade just before a release so I'll do this after the 8.6
> branch is cut.
> Shouldn't be a big deal, from Zookeeper:
> "This is the second release for 3.6 branch.
> It is a bugfix release and it fixes a few compatibility issues with
> applications built for ZooKeeper 3.5. The upgrade from 3.5.7 to 3.6.1 can be
> executed as usual, no particular additional upgrade procedure is needed.
> ZooKeeper 3.6.1 clients are compatible with 3.5 servers as long as you are
> not using new APIs not present in 3.5."
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
