[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145999#comment-17145999
]
Atri Sharma edited comment on SOLR-14588 at 6/26/20, 4:14 AM:
--------------------------------------------------------------
[~erickerickson] Thank you for proactively fixing the test!
Did you get a chance to see the PR I raised late last night?
(https://github.com/apache/lucene-solr/pull/1615)This fixes the same by not
printing circuit breaker timings when circuit breakers are disabled. Would you
feel that this is a longer term strategy to follow since this insulates the
circuit breaker response messages breaking existing tests and only affecting
ones which want to run with circuit breakers enabled?
was (Author: atris):
[~erickerickson] Thank you for proactively fixing the test!
Did you get a chance to see the PR I raised late last night
(https://github.com/apache/lucene-solr/pull/1615)? This fixes the same by not
printing circuit breaker timings when circuit breakers are disabled. Would you
feel that this is a longer term strategy to follow since this insulates the
circuit breaker response messages breaking existing tests and only affecting
ones which want to run with circuit breakers enabled?
> Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker
> ------------------------------------------------------------------
>
> Key: SOLR-14588
> URL: https://issues.apache.org/jira/browse/SOLR-14588
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Atri Sharma
> Assignee: Atri Sharma
> Priority: Major
> Time Spent: 8h
> Remaining Estimate: 0h
>
> This Jira tracks addition of circuit breakers in the search path and
> implements JVM based circuit breaker which rejects incoming search requests
> if the JVM heap usage exceeds a defined percentage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
