[
https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142864#comment-17142864
]
Erick Erickson commented on SOLR-13268:
---------------------------------------
I'm thinking of reverting _testing_ to use synchronous logging. I don't
particularly like that solution, as then we're testing something different in
the test environment than production.
OTOH, the "logging bleed" is happening, I believe, when the loggers shutdown
and don't completely flush the queue. In the real world this happens when we
bring Solr up and down. Tests do this artificially often. It's not even clear
to me that the messages would be lost when "real world" Solr is being shut
down, they do come out in the next test so they didn't disappear into the ether
or we wouldn't be getting this message.
So frankly I don't think it's worth the effort of tracking this down. Async
logging has been in place for a long time and this is the only place we see a
problem.
I'll push this change in a day or three absent strenuous objections. If people
insist on NOT reverting, I'll unassign it.
> Clean up any test failures resulting from defaulting to async logging
> ---------------------------------------------------------------------
>
> Key: SOLR-13268
> URL: https://issues.apache.org/jira/browse/SOLR-13268
> Project: Solr
> Issue Type: Bug
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Attachments: SOLR-13268-flushing.patch, SOLR-13268.patch,
> SOLR-13268.patch, SOLR-13268.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This is a catch-all for test failures due to the async logging changes. So
> far, the I see a couple failures on JDK13 only. I'll collect a "starter set"
> here, these are likely systemic, once the root cause is found/fixed, then
> others are likely fixed as well.
> JDK13:
> ant test -Dtestcase=TestJmxIntegration -Dtests.seed=54B30AC62A2D71E
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=lv-LV
> -Dtests.timezone=Asia/Riyadh -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> ant test -Dtestcase=TestDynamicURP -Dtests.seed=54B30AC62A2D71E
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=rwk
> -Dtests.timezone=Australia/Brisbane -Dtests.asserts=true
> -Dtests.file.encoding=UTF-8
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
