[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140997#comment-17140997
]
Dawid Weiss commented on LUCENE-9411:
-------------------------------------
Can you move all those blocks into a separate single file (and apply to those
projects that need it), Erik?
{code:java}
+ // Prometeus exporter classes reference this although it's not part of the
exported classpath
+ // which causes odd warnings during compilation. Shut it up with an
explicit-version
+ // compile-only dependency (!).
+ compileOnly 'com.google.errorprone:error_prone_annotations:2.1.3'{code}
It should be included from top-level (gradle/hacks/findbugs-annotations.gradle)
and look something like this:
{code:java}
configure([project(":solr:foo"), project(":solr:bar")]) {
plugins.withType(JavaPlugin) {
// blah blah
dependencies {
compileOnly 'com.google.errorprone:error_prone_annotations:2.1.3'
}
}
}{code}
The "withType" bit is needed just in case the file is included before the java
plugin is applied - then dependencies configuration wouldn't be resolved
properly.
> Fail complation on warnings
> ---------------------------
>
> Key: LUCENE-9411
> URL: https://issues.apache.org/jira/browse/LUCENE-9411
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Labels: build
> Attachments: LUCENE-9411.patch, LUCENE-9411.patch, LUCENE-9411.patch,
> annotations-warnings.patch
>
>
> Moving this over here from SOLR-11973 since it's part of the build system and
> affects Lucene as well as Solr. You might want to see the discussion there.
> We have a clean compile for both Solr and Lucene, no rawtypes, unchecked,
> try, etc. warnings. There are some peculiar warnings (things like
> SuppressFBWarnings, i.e. FindBugs) that I'm not sure about at all, but let's
> assume those are not a problem. Now I'd like to start failing the compilation
> if people write new code that generates warnings.
> From what I can tell, just adding the flag is easy in both the Gradle and Ant
> builds. I still have to prove out that adding -Werrors does what I expect,
> i.e. succeeds now and fails when I introduce warnings.
> But let's assume that works. Are there objections to this idea generally? I
> hope to have some data by next Monday.
> FWIW, the Lucene code base had far fewer issues than Solr, but
> common-build.xml is in Lucene.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
