madrob commented on a change in pull request #1556:
URL: https://github.com/apache/lucene-solr/pull/1556#discussion_r436901874
##########
File path: solr/core/src/java/org/apache/solr/core/RequestParams.java
##########
@@ -85,32 +85,25 @@ public static ParamSet createParamSet(Map map, Long
version) {
* This converts Lists to arrays of strings. Because Solr expects
* params to be String[]
*/
-
- @SuppressWarnings({"unchecked", "rawtypes"})
- private static Map getMapCopy(Map value) {
- @SuppressWarnings({"rawtypes"})
- Map copy = new LinkedHashMap<>();
- for (Object o1 : value.entrySet()) {
- @SuppressWarnings({"rawtypes"})
- Map.Entry entry = (Map.Entry) o1;
+ private static Map<String,String[]> getMapCopy(Map<String,?> value) {
+ Map<String, String[]> copy = new LinkedHashMap<>();
+ for (Map.Entry<String, ?> entry : value.entrySet()) {
if ("".equals(entry.getKey())) {
- copy.put(entry.getKey(), entry.getValue());
- continue;
+ // nocommit
+ // copy.put(entry.getKey(), entry.getValue());
Review comment:
I don't understand why this case is special and gets treated differently
rather than converting the value to a `String[]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
