tflobbe commented on a change in pull request #1553:
URL: https://github.com/apache/lucene-solr/pull/1553#discussion_r436062720
##########
File path:
lucene/queries/src/test/org/apache/lucene/queries/function/TestFunctionScoreQuery.java
##########
@@ -244,4 +247,33 @@ public void testAccessToValueSource() throws Exception {
}
+ public void testScoreMode() throws Exception {
+ // Value Source doesn't need scores
+ assertInnerScoreMode(ScoreMode.COMPLETE_NO_SCORES, ScoreMode.COMPLETE,
DoubleValuesSource.fromDoubleField("foo"));
Review comment:
Ah, right. ValueSources like `MultiplicativeBoostValuesSource` will need
scores because it uses the `DoubleValues scores` argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
