dsmiley opened a new pull request #1550: URL: https://github.com/apache/lucene-solr/pull/1550
I switched from "java-library" type of Gradle plugin/module to more plainly "java" because this module isn't just some library, it's closer to an app. I tried type "application" but I didn't have the same control that the "JavaExec" task gives you. One consequence of not using "java-library" is that the names of the categories of dependencies are different, and so this appears odd/unusual relative to the other modules. I did not convert "collation" and "shingle" Ant targets, but I put there the two-line CLI equivalents for both in the form of a comment. I ram them and they worked... albeit a confusion in one of the perl scripts that thought "darwin" OS was ==~ Windows simply because it contained "win" :-). Notice the style of "getEnWiki" and "getGeoNames" and "getTop100kWikiWordFiles": One task that does all it needs to do by adding a final step in doLast. Now notice a different style: "reuters" (depending on extractReuters depending on getReuters). This is more verbose, but admittedly for this case it has to do more. I'm not well versed enough in Gradle to know which style is preferable. I lean towards short & concise. The current state is a nocommit IMO; need to harmonize the approaches. I did not convert https://www-2.cs.cmu.edu/afs/cs.cmu.edu/project/theo-20/www/data/news20.tar.gz (aka news20) or https://people.csail.mit.edu/u/j/jrennie/public_html/20Newsgroups/20news-18828.tar.gz or https://kdd.ics.uci.edu/databases/20newsgroups/mini_newsgroups.tar.gz (aka mini-news) because I could not find .alg files that used them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
