[ 
https://issues.apache.org/jira/browse/SOLR-11334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117038#comment-17117038
 ] 

David Smiley commented on SOLR-11334:
-------------------------------------

Thanks but the patch doesn't fix the root cause; it works around it.  The root 
cause is clearly {{SolrPluginUtils.split}} for producing such empty strings in 
the first place.  I filed a PR accomplishing the fix.  I like your test!

> UnifiedSolrHighlighter returns an error when hl.fl delimited by ", "
> --------------------------------------------------------------------
>
>                 Key: SOLR-11334
>                 URL: https://issues.apache.org/jira/browse/SOLR-11334
>             Project: Solr
>          Issue Type: Bug
>          Components: highlighter
>    Affects Versions: 6.6
>         Environment: Ubuntu 17.04 (GNU/Linux 4.10.0-33-generic x86_64)
> Java HotSpot 64-Bit Server VM(build 25.114-b01, mixed mode)
>            Reporter: Yasufumi Mizoguchi
>            Priority: Trivial
>         Attachments: SOLR-11334.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> UnifiedSolrHighlighter(hl.method=unified) misjudge the zero-length string as 
> a field name and returns an error when hl.fl delimited by ", "
> request:
> {code}
> $ curl -XGET 
> "http://localhost:8983/solr/techproducts/select?fl=name,%20manu&hl.fl=name,%20manu&hl.method=unified&hl=on&indent=on&q=corsair&wt=json";
> {code}
> response:
> {code}
> {
>   "responseHeader":{
>     "status":400,
>     "QTime":8,
>     "params":{
>       "q":"corsair",
>       "hl":"on",
>       "indent":"on",
>       "fl":"name, manu",
>       "hl.fl":"name, manu",
>       "hl.method":"unified",
>       "wt":"json"}},
>   "response":{"numFound":2,"start":0,"docs":[
>       {
>         "name":"CORSAIR ValueSelect 1GB 184-Pin DDR SDRAM Unbuffered DDR 400 
> (PC 3200) System Memory - Retail",
>         "manu":"Corsair Microsystems Inc."},
>       {
>         "name":"CORSAIR  XMS 2GB (2 x 1GB) 184-Pin DDR SDRAM Unbuffered DDR 
> 400 (PC 3200) Dual Channel Kit System Memory - Retail",
>         "manu":"Corsair Microsystems Inc."}]
>   },
>   "error":{
>     "metadata":[
>       "error-class","org.apache.solr.common.SolrException",
>       "root-error-class","org.apache.solr.common.SolrException"],
>     "msg":"undefined field ",
>     "code":400}}
> {code}
> DefaultHighlighter's response:
> {code}
> {
>   "responseHeader":{
>     "status":0,
>     "QTime":5,
>     "params":{
>       "q":"corsair",
>       "hl":"on",
>       "indent":"on",
>       "fl":"name, manu",
>       "hl.fl":"name, manu",
>       "hl.method":"original",
>       "wt":"json"}},
>   "response":{"numFound":2,"start":0,"docs":[
>       {
>         "name":"CORSAIR ValueSelect 1GB 184-Pin DDR SDRAM Unbuffered DDR 400 
> (PC 3200) System Memory - Retail",
>         "manu":"Corsair Microsystems Inc."},
>       {
>         "name":"CORSAIR  XMS 2GB (2 x 1GB) 184-Pin DDR SDRAM Unbuffered DDR 
> 400 (PC 3200) Dual Channel Kit System Memory - Retail",
>         "manu":"Corsair Microsystems Inc."}]
>   },
>   "highlighting":{
>     "VS1GB400C3":{
>       "name":["<em>CORSAIR</em> ValueSelect 1GB 184-Pin DDR SDRAM Unbuffered 
> DDR 400 (PC 3200) System Memory - Retail"],
>       "manu":["<em>Corsair</em> Microsystems Inc."]},
>     "TWINX2048-3200PRO":{
>       "name":["<em>CORSAIR</em>  XMS 2GB (2 x 1GB) 184-Pin DDR SDRAM 
> Unbuffered DDR 400 (PC 3200) Dual Channel Kit System"],
>       "manu":["<em>Corsair</em> Microsystems Inc."]}}}
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to