ErickErickson commented on pull request #1533: URL: https://github.com/apache/lucene-solr/pull/1533#issuecomment-633235060
> Thanks for doing this! > > There are subclasses of FacetParser that are located as inner classes within FacetRequest. I think they should be moved to be inner classes of FacetParser. WDYT? The point is logical organization. Yeah, good catch. I've been concentrating on getting the warnings out and, especially when it comes to this kind of organization miss some of the higher-level considerations, which is one reason I'm glad for your review. Anyway, another PR coming later today. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
