[
https://issues.apache.org/jira/browse/SOLR-14280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14280:
----------------------------------
Attachment: getmessages.txt
Status: Patch Available (was: Patch Available)
It'd be trivial to add a check for mentioning getMessage or getCause (or any
other string/pattern for that matter) to the Gradle logging call validation.
I've attached the results of one run, < 90 such calls were flagged against
current master.
It'd be a separate JIRA, but this could be an optional check or a mandatory
one. If the latter, someone needs to volunteer to address them all. I'd be
happy to make the change to the logging validation check and provide any
coaching in using it. I suspect it'd never actually be used if optional, so I'd
prefer mandatory.
NOTE: there's already a mechanism (adding //logok to the log line) to suppress
the validation checks for an individual logging line as necessary, so we could
leave those calls in where appropriate even if the check is not optional. And
it'd also remove some of the if (log.is###Enabled) clauses.
The way logging validation works from inside IntelliJ means that navigating to
anything that is reported by logging validation is just clicking on the error
message (other IDEs IDK) so it's not as painful as trying to go from the
attached report.
If someone wants to volunteer, make a JIRA for adding this check to logging
validation, assign it to me (or @mention me in the text) and I'll make the
check happen.
> SolrConfig logging not helpful
> ------------------------------
>
> Key: SOLR-14280
> URL: https://issues.apache.org/jira/browse/SOLR-14280
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Andras Salamon
> Priority: Minor
> Attachments: SOLR-14280-01.patch, SOLR-14280-02.patch, getmessages.txt
>
>
> SolrConfig prints out a warning message if it's not able to add files to the
> classpath, but this message is not too helpful:
> {noformat}
> o.a.s.c.SolrConfig Couldn't add files from
> /opt/cloudera/parcels/CDH-7.1.1-1.cdh7.1.1.p0.1850855/lib/solr/dist filtered
> by solr-langid-\d.*\.jar to classpath:
> /opt/cloudera/parcels/CDH-7.1.1-1.cdh7.1.1.p0.1850855/lib/solr/
> dist {noformat}
> The reason should be at the end of the log message but it's just repeats the
> problematic file name.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
