janhoy commented on a change in pull request #1528:
URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r427627240
##########
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
##########
@@ -236,21 +235,19 @@ public void call(ClusterState clusterState, ZkNodeProps
message, NamedList resul
}
String baseUrl = zkStateReader.getBaseUrlForNodeName(nodeName);
- //in the new mode, create the replica in clusterstate prior to
creating the core.
+ //create the replica in clusterstate (i.e. ZK) prior to creating the
core.
Review comment:
I think we still can use 'clusterstate' as a generic term? When I read
it in a sentence like this I do not read it as the file clusterstate.json, but
as the cluster state. Perhaps we could consistenly write it as "cluster state"
instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
