[ 
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110695#comment-17110695
 ] 

Ilan Ginzburg commented on SOLR-12823:
--------------------------------------

I’m sharing a work in progress (draft) Pull Request, but almost done: 
[https://github.com/apache/lucene-solr/pull/1528]

I believe “production” code is complete, but:
 * {{org.apache.solr.cloud.autoscaling.sim}} assumes stateFormat 1 and the 
presence of {{/clusterstate.json}}. I didn’t look into what changes are 
required there. Some code got commented out in order to compile, tests are 
failing.
 * {{TestZkChroot}} breaks. That test needs to be written differently, possibly 
by starting a local SolrCloud with a non hard coded chroot (rather than 
{{/solr}}). 
 * {{BasicZkTest}} fails as well. I’d like to remove it unless somebody thinks 
it has value.

This PR removes all code dealing with {{/clusterstate.json}} in Zookeeper. It 
also removes {{MIGRATESTATEVERSION}} Collection API action and the notion of 
“legacyCloud” (legacyCloud mode no longer supported).

Fun fact: all OverseerTest collections were created in stateFormat 1.

I’d like to start getting feedback on these changes. Will look in the meantime 
at changes required in the autoscaling sim code (SOLR-14486), unless you want 
to do that [~ab] ?

Any comments or guidance on how to continue from here are most welcome. This is 
one of my first PR’s on lucene-solr (actually the second given SOLR-14473 was 
merged three hours ago, thanks [~mdrob]!).

> remove clusterstate.json in Lucene/Solr 8.0
> -------------------------------------------
>
>                 Key: SOLR-12823
>                 URL: https://issues.apache.org/jira/browse/SOLR-12823
>             Project: Solr
>          Issue Type: Task
>            Reporter: Varun Thacker
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> clusterstate.json is an artifact of a pre 5.0 Solr release. We should remove 
> that in 8.0
> It stays empty unless you explicitly ask to create the collection with the 
> old "stateFormat" and there is no reason for one to create a collection with 
> the old stateFormat.
> We should also remove the "stateFormat" argument in create collection
> We should also remove MIGRATESTATEVERSION as well
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to