[
https://issues.apache.org/jira/browse/SOLR-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrzej Bialecki resolved SOLR-14423.
-------------------------------------
Fix Version/s: 8.6
Resolution: Fixed
The final fix initializes {{CoreContainer.solrClientCache}} instance and uses
it in most other places.
One odd duck was the {{CalciteSolrDriver}}, which is configured statically by
the JDBC framework. Here the CoreContainer explicitly finds that singleton
instance and sets it to use the common SolrClientCache.
Additionally, other static members of {{StreamHandler}} are now kept in an
{{ObjectCache}} instance, which is again initialized in
{{CoreContainer.objectCache}}.
These changes should improve performance of /sql handler and increase the
isolation of CoreContainers.
Thank you David, Christine, and especially Joel for some insights into the
streaming's inner workings and for additional testing.
> static caches in StreamHandler ought to move to CoreContainer lifecycle
> -----------------------------------------------------------------------
>
> Key: SOLR-14423
> URL: https://issues.apache.org/jira/browse/SOLR-14423
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
> Reporter: David Smiley
> Assignee: Andrzej Bialecki
> Priority: Major
> Fix For: 8.6
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> StreamHandler (at "/stream") has several statically declared caches. I think
> this is problematic, such as in testing wherein multiple nodes could be in
> the same JVM. One of them is more serious -- SolrClientCache which is
> closed/cleared via a SolrCore close hook. That's bad for performance but
> also dangerous since another core might want to use one of these clients!
> CC [~jbernste]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]