[
https://issues.apache.org/jira/browse/LUCENE-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105587#comment-17105587
]
ASF subversion and git services commented on LUCENE-9350:
---------------------------------------------------------
Commit 05ba52bd21c780692c367c7ea316192047fec4cb in lucene-solr's branch
refs/heads/branch_8_5 from Alan Woodward
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=05ba52b ]
LUCENE-9350: Don't hold references to large automata on FuzzyQuery (#1467)
LUCENE-9068 moved fuzzy automata construction into FuzzyQuery itself. However,
this has the nasty side-effect of blowing up query caches that expect queries
to be
fairly small. This commit restores the previous behaviour of caching the large
automata
on an AttributeSource shared between segments, while making the construction a
bit clearer by factoring it out into a package-private FuzzyAutomatonBuilder.
> Don't cache automata on FuzzyQuery
> ----------------------------------
>
> Key: LUCENE-9350
> URL: https://issues.apache.org/jira/browse/LUCENE-9350
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Major
> Fix For: 8.6
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> LUCENE-9068 moved construction of FuzzyQuery's automaton directly onto the
> query itself. However, as SOLR-14428 demonstrates, this ends up blowing up
> query caches that assume query objects are fairly small when calculating
> their memory usage. We should move automaton construction back into
> FuzzyTermsEnum, while keeping as much of the nice refactoring of LUCENE-9068
> as possible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
