[
https://issues.apache.org/jira/browse/LUCENE-9364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved LUCENE-9364.
------------------------------------
Resolution: Invalid
Oops, wrong project. I opened a Solr Jira for this.
> Fix side effect of logging call in LogUpdateProcessorFactory
> ------------------------------------------------------------
>
> Key: LUCENE-9364
> URL: https://issues.apache.org/jira/browse/LUCENE-9364
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
>
> There's a logging calls in LogUpdateProcessorFactory like this:
> if (log.isInfoEnabled()) {
> log.info(getLogStringAndClearRspToLog());
> }
> immediately followed a WARN level all to log slow queries if the query is
> slow.
> getLogStringAndClearRspToLog has a call in it:
> *rsp.getToLog().clear(); // make it so SolrCore.exec won't log this
> again*
> This has been true since at least Solr 7.5. It's wrong for two reasons:
> 1> logging calls shouldn't have side effects like this in the first place
> 2> Right after that call, there's also a call to (potentially) log slow
> requests, and the rsp.getToLog().clear() will already have been called if
> logging at info level.
> I'll fix shortly, although since it's been like this for a long time, I'm not
> in a panic thinking I introduced this recently.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
