gunasekhardora commented on a change in pull request #1371:
URL: https://github.com/apache/lucene-solr/pull/1371#discussion_r418926468



##########
File path: 
solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java
##########
@@ -128,6 +128,28 @@ field collapsing (with ngroups) when the number of 
distinct groups
   public static final String HINT_TOP_FC = "top_fc";
   public static final String HINT_MULTI_DOCVALUES = "multi_docvalues";
 
+  public enum NullPolicy {
+    IGNORE("ignore", 0),

Review comment:
       @madrob Removed them. Added an unit test to validate if null policy is 
an illegal argument as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to