mayya-sharipova commented on a change in pull request #1351: URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r417400122
########## File path: lucene/core/src/java/org/apache/lucene/search/FilteringFieldComparator.java ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.search; + +import java.io.IOException; + +/** + * Decorates a wrapped FieldComparator to add a functionality to skip over non-competitive docs. + * FilteringFieldComparator provides two additional functions for a FieldComparator: + * 1) {@code competitiveIterator()} that returns an iterator over + * competitive docs that are stronger than already collected docs. + * 2) {@code setCanUpdateIterator()} that notifies the comparator when it is ok to start updating its internal iterator. + * This method is called from a collector to inform the comparator to start updating its iterator. + */ +public abstract class FilteringFieldComparator<T> extends FieldComparator<T> { + final FieldComparator<T> in; + + public FilteringFieldComparator(FieldComparator<T> in) { + this.in = in; + } + + protected abstract DocIdSetIterator competitiveIterator(); Review comment: Thanks @jpountz, indeed the suggested structure is much better. addressed in 7120424ff ########## File path: lucene/core/src/java/org/apache/lucene/search/FilteringFieldComparator.java ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.search; + +import java.io.IOException; + +/** + * Decorates a wrapped FieldComparator to add a functionality to skip over non-competitive docs. + * FilteringFieldComparator provides two additional functions for a FieldComparator: + * 1) {@code competitiveIterator()} that returns an iterator over + * competitive docs that are stronger than already collected docs. + * 2) {@code setCanUpdateIterator()} that notifies the comparator when it is ok to start updating its internal iterator. + * This method is called from a collector to inform the comparator to start updating its iterator. + */ +public abstract class FilteringFieldComparator<T> extends FieldComparator<T> { + final FieldComparator<T> in; + + public FilteringFieldComparator(FieldComparator<T> in) { + this.in = in; + } + + protected abstract DocIdSetIterator competitiveIterator(); + + protected abstract void setCanUpdateIterator() throws IOException; Review comment: addressed in 7120424ff ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
