[
https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095433#comment-17095433
]
Erick Erickson edited comment on LUCENE-7788 at 4/29/20, 1:02 PM:
------------------------------------------------------------------
Dawid:
Yep, bunches. If it's OK I'd rather leave them until the first pass is done,
there's some extra checks that'll be obsolete, as well as a bunch of cruft. I'm
making good progress on the cleaning all the log calls up, I'm hoping to be
done sometime this coming weekend. I certainly expect to remove them all and
generally clean up that file, it's very messy right now.
There's a bunch of cruft in the validation file that I'll remove before I'm
done, for instance:
- a check to catch "()" rather than "{}" which I've inadvertently typed in a
few times
- a bunch of specific checks for individual files etc. things that won't be
flagged after I've gotten it all done
- commented out hacks to run against 8x by pathing to someplace completely
different.
- etc.
I can make them some other string if anyone's trying to integrate nocommit
checks for gradle build files, otherwise I'll ask that you just ignore them for
another week, let me know.
was (Author: erickerickson):
Yep, bunches. If it's OK I'd rather leave them until the first pass is done,
there's some extra checks that'll be obsolete, as well as a bunch of cruft. I'm
making good progress on the cleaning all the log calls up, I'm hoping to be
done sometime this coming weekend. I certainly expect to remove them all and
generally clean up that file, it's very messy right now.
There's a bunch of cruft in the validation file that I'll remove before I'm
done, for instance:
- a check to catch "()" rather than "{}" which I've inadvertently typed in a
few times
- a bunch of specific checks for individual files etc. things that won't be
flagged after I've gotten it all done
- commented out hacks to run against 8x by pathing to someplace completely
different.
- etc.
I can make them some other string if anyone's trying to integrate nocommit
checks for gradle build files, otherwise I'll ask that you just ignore them for
another week, let me know.
> fail precommit on unparameterised log messages and examine for wasted
> work/objects
> ----------------------------------------------------------------------------------
>
> Key: LUCENE-7788
> URL: https://issues.apache.org/jira/browse/LUCENE-7788
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: LUCENE-7788.patch, LUCENE-7788.patch, gradle_only.patch,
> gradle_only.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> SOLR-10415 would be removing existing unparameterised log.trace messages use
> and once that is in place then this ticket's one-line change would be for
> 'ant precommit' to reject any future unparameterised log.trace message use.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
