romseygeek commented on a change in pull request #1440:
URL: https://github.com/apache/lucene-solr/pull/1440#discussion_r413692946
##########
File path:
lucene/core/src/java/org/apache/lucene/index/SortedDocValuesWriter.java
##########
@@ -79,11 +78,6 @@ public void addValue(int docID, BytesRef value) {
lastDocID = docID;
}
- @Override
- public void finish(int maxDoc) {
- updateBytesUsed();
- }
Review comment:
It was always called either immediately before `flush` or
`getDocComparator`, so it seemed to make sense to just fold it directly into
those methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
