madrob commented on a change in pull request #1432: URL: https://github.com/apache/lucene-solr/pull/1432#discussion_r412490678
########## File path: solr/core/src/java/org/apache/solr/pkg/PackageListeners.java ########## @@ -63,13 +63,13 @@ public synchronized void removeListener(Listener listener) { } synchronized void packagesUpdated(List<PackageLoader.Package> pkgs) { - MDCLoggingContext.setCore(core); Review comment: I was under the impression that it setCore/clear still work even if the core was null. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org