[ 
https://issues.apache.org/jira/browse/SOLR-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089049#comment-17089049
 ] 

David Smiley commented on SOLR-14423:
-------------------------------------

I propose we add a general purpose enhancement to CoreContainer to help 
multiple plugins that might want to have core-wide facilities.  Imagine the 
CoreContainer offering a ConcurrentMap keyed by class and value is an instance 
of the class.  On CoreContainer shutdown, these are examined to see which are 
closeable, and they are then closed.  The typed nature would mean you can't 
usefully add something generic like a String but I think that's a fine 
trade-off for some type safety.

> static caches in StreamHandler ought to move to CoreContainer lifecycle
> -----------------------------------------------------------------------
>
>                 Key: SOLR-14423
>                 URL: https://issues.apache.org/jira/browse/SOLR-14423
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: streaming expressions
>            Reporter: David Smiley
>            Priority: Major
>
> StreamHandler (at "/stream") has several statically declared caches.  I think 
> this is problematic, such as in testing wherein multiple nodes could be in 
> the same JVM.  One of them is more serious -- SolrClientCache which is 
> closed/cleared via a SolrCore close hook.  That's bad for performance but 
> also dangerous since another core might want to use one of these clients!
> CC [~jbernste]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to