[ 
https://issues.apache.org/jira/browse/SOLR-14421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088629#comment-17088629
 ] 

Uwe Schindler commented on SOLR-14421:
--------------------------------------

I am fine with that. It's all commented out, so its up to the user to get it 
running correctly depending on how his options looks like. The whitespace 
should be no issue here. Nevertheless when file system paths are involved, 
additional quoting may be required, but this is up to the user and not our deal 
(this refers to the last setting that has some example path).

> New examples in solr.in.cmd in Solr 8.5 don't work as provided
> --------------------------------------------------------------
>
>                 Key: SOLR-14421
>                 URL: https://issues.apache.org/jira/browse/SOLR-14421
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 8.5, 8.5.1
>            Reporter: Colvin Cowie
>            Assignee: Jan Høydahl
>            Priority: Trivial
>             Fix For: 8.6
>
>         Attachments: SOLR-14421.patch
>
>
>  
> These SOLR_OPTS examples need to be prefixed with _set_ and don't work when 
> surrounded with quotes 
> [https://github.com/apache/lucene-solr/blob/master/solr/bin/solr.in.cmd#L194-L199]
> {noformat}
> REM SOLR_OPTS="%SOLR_OPTS% -Dsolr.environment=prod"
> REM Specifies the path to a common library directory that will be shared 
> across all cores.
> REM Any JAR files in this directory will be added to the search path for Solr 
> plugins.
> REM If the specified path is not absolute, it will be relative to 
> `%SOLR_HOME%`.
> REM SOLR_OPTS="%SOLR_OPTS% -Dsolr.sharedLib=/path/to/lib"
> {noformat}
> Without set you will get "_'SOLR_OPTS' is not recognized as an internal or 
> external command, operable program or batch file_."
> After adding _set,_ with the quotes you get _"-Dsolr.environment=prod was 
> unexpected at this time."_
> I'll attach a patch
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to