[
https://issues.apache.org/jira/browse/SOLR-14420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088359#comment-17088359
]
Uwe Schindler commented on SOLR-14420:
--------------------------------------
Do you have a PR already? It's long ago since I argued about this. I have to
first understand this again.
> Address AuthenticationPlugin TODO redeclare params as HttpServletRequest &
> HttpServletResponse
> ----------------------------------------------------------------------------------------------
>
> Key: SOLR-14420
> URL: https://issues.apache.org/jira/browse/SOLR-14420
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: security
> Reporter: Mike Drob
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This was noted in SOLR-11692 and then I think the surrounding code change
> more in SOLR-12290, but the TODO remained unaddressed. We can declare this as
> HttpServletRequest/Response and all of the usages still work. There are
> plenty of implementations where we just do a cast anyway, and don't even do
> instanced checks.
> I noticed this change for an external auth plugin that I'm working on that
> appears to have issues handling casts between ServletRequest and the
> CloseShield wrapper classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
