jpountz commented on a change in pull request #1434: LUCENE-9324: Add an ID to 
SegmentCommitInfo
URL: https://github.com/apache/lucene-solr/pull/1434#discussion_r410185034
 
 

 ##########
 File path: 
lucene/backward-codecs/src/test/org/apache/lucene/index/TestBackwardsCompatibility.java
 ##########
 @@ -862,7 +862,8 @@ public void testAddOldIndexesReader() throws IOException {
       TestUtil.addIndexesSlowly(w, reader);
       w.close();
       reader.close();
-            
+      SegmentInfos si = SegmentInfos.readLatestCommit(targetDir);
+      assertEquals("all SCIs should have an id now", 0, 
si.asList().stream().filter(sci -> sci.getId() == null).count());
 
 Review comment:
   here too?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to