madrob commented on a change in pull request #1432: SOLR-14404 CoreContainer
level custom requesthandlers
URL: https://github.com/apache/lucene-solr/pull/1432#discussion_r409694609
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -648,8 +655,8 @@ public void load() {
pkiAuthenticationPlugin.initializeMetrics(solrMetricsContext,
"/authentication/pki");
TracerConfigurator.loadTracer(loader,
cfg.getTracerConfiguratorPluginInfo(), getZkController().getZkStateReader());
packageLoader = new PackageLoader(this);
- containerHandlers.getApiBag().register(new
AnnotatedApi(packageLoader.getPackageAPI().editAPI), Collections.EMPTY_MAP);
- containerHandlers.getApiBag().register(new
AnnotatedApi(packageLoader.getPackageAPI().readAPI), Collections.EMPTY_MAP);
+
containerHandlers.getApiBag().registerObject(packageLoader.getPackageAPI().editAPI);
Review comment:
There's a minor inconsistency here between edit/read and write/read, maybe
we can standardize on one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
